Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev modu web#113 #117

Merged
merged 4 commits into from
Oct 10, 2020
Merged

Dev modu web#113 #117

merged 4 commits into from
Oct 10, 2020

Conversation

lovit
Copy link
Member

@lovit lovit commented Oct 10, 2020

Pull Request

Korpora에 기여해 주셔서 감사합니다.

해당 Pull Request를 제출하기 전에 아래 사항이 완료되었는지 확인 부탁드립니다:

  • 작성한 코드가 어떤 에러나 경고 없이 실행이 되나요?
  • 작성한 코드에 대한 테스트 코드를 만드셨나요? (경로 : Korpora/test)
  • 기존 코드 역시 에러 없이 수행이 되겠죠?

1. 해당 PR은 어떤 내용인가요?

모두의 말뭉치: 웹 말뭉치에서 텍스트 부분만 로딩하는 기능과 사용법

2. PR과 관련된 이슈가 있나요?

#103, #113

@lovit lovit requested a review from ratsgo October 10, 2020 08:34
ratsgo
ratsgo approved these changes Oct 10, 2020
View reviewed changes
Copy link
Member

@ratsgo ratsgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 결과 이상없이 동작함을 확인하였습니다.
README 오타 수정 커밋 하나 했어요.
고생 많으셨습니다.

@lovit
Copy link
Member Author

lovit commented Oct 10, 2020

오타 교정부분 확인했습니다. 감사합니다.

@lovit lovit merged commit 5899814 into dev Oct 10, 2020
@lovit lovit deleted the dev-modu-web#113 branch October 12, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ratsgo ratsgo ratsgo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lovit @ratsgo